ci: use rust toolchain v1.71.0 #1146
Merged
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
commented
Sep 7, 2023
hugocaillard
commented
Sep 7, 2023
MicaiahReid
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent issue in the CI is caused by the fact that our version of v8 doesn't build with the latest rustc version (1.72.0 that became the stable release 2 weeks ago).
Let's fix the version to 1.71.0 (latest version able to build clarinet) both in the CI and locally (rust-toolchain file).
In the future, I think we should always use stable (both in CI and locally).
This will be possible once we remove deno and v8 from the dependencies (in the coming weeks)